[PATCH] D85050: [GlobalISel] Combine (logic_op (op x...), (op y...)) -> (op (logic_op x, y))

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

Tests missing?



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:60
+  OperandBuildSteps StepFns; /// Operands to be added to the instruction.
+  InstructionBuildSteps() {}
+  InstructionBuildSteps(unsigned Opcode, const OperandBuildSteps &StepFns)
----------------
`= default`?


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:69
+  SmallVector<InstructionBuildSteps, 2> InstrsToBuild;
+  InstructionStepsMatchInfo() {}
+  InstructionStepsMatchInfo(
----------------
same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85050/new/

https://reviews.llvm.org/D85050