[PATCH] D85632: [Attributor] Implement AAPotentialValues

Mon Aug 10 20:05:39 PDT 2020

jdoerfert added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:7358
+    case Instruction::Mul:
+      return LHS * RHS;
+    case Instruction::UDiv:
----------------
okura wrote:
> jdoerfert wrote:
> > Why do we have the copy sometimes and sometimes not? Are the operators missing in the APInt class? If so, we should fix that in a pre-patch first.
> > Are the operators missing in the APInt class?
> Yes, there are only compound assignment operators for some opcodes. I'll make a new patch for this.
Why do we want the assignment operators? Why not just LHS + RHS?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85632/new/

https://reviews.llvm.org/D85632