[PATCH] D85684: [InstSimplify] Forbid undef folds in expandBinOp
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 18:40:54 PDT 2020
aqjune added a comment.
In D85684#2208630 <https://reviews.llvm.org/D85684#2208630>, @jdoerfert wrote:
> Why is the test not part of this?
Maybe it is because an operation on undef is already folded before expandBinOp is reached. Is it right @nikic? I think having a working test here likely means we found another miscompilation regarding undef and distributivity law.
If `select c, undef, x --> x` is disabled later, it will leave the undef constant, making the test at select.ll valid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85684/new/
https://reviews.llvm.org/D85684
More information about the llvm-commits
mailing list