[PATCH] D85617: [OpenMP][OMPBuilder] Adding support for `omp single`

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Looks fine to me. A few nits.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:315-318
+  /// \param BufSize Number of elements in the buffer
+  /// \param CpyBuf List of pointers to data to be copied
+  /// \param CpyFn function to call for copying data
+  /// \param DidIt flag variable; 1 for 'single' thread, 0 otherwise
----------------
Full stop missing.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:318
+  /// \param CpyFn function to call for copying data
+  /// \param DidIt flag variable; 1 for 'single' thread, 0 otherwise
+  ///
----------------
what is the full form of this name?
Would IsSingle be a better name?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:320
+  ///
+  /// \return he insertion position *after* the CopyPrivate call.
+
----------------
Nit: The


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85617/new/

https://reviews.llvm.org/D85617