[PATCH] D85642: [LLD][ELF] - Update and fix gnu-ifunc* tests.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lld/test/ELF/gnu-ifunc-plt-i386.s:15
 
-// Check that the IRELATIVE relocations are after the JUMP_SLOT in the plt
+// Check that the IRELATIVE relocations are placed to the .rel.dyn section after
+// other regular relocations (e.g. GLOB_DAT).
----------------
Perhaps switch to `/// ` while you are updating the comment.


================
Comment at: lld/test/ELF/gnu-ifunc-plt-i386.s:45
 // DISASM:      <_start>:
-// DISASM-NEXT:    4011b6:       calll   0x401200 <zed2+0x401200>
-// DISASM-NEXT:                  calll   0x401210 <zed2+0x401210>
-// DISASM-NEXT:                  calll   0x4011e0 <bar2 at plt>
-// DISASM-NEXT:                  calll   0x4011f0 <zed2 at plt>
+// DISASM-NEXT:    4011de:       calll   0x401230 <zed2+0x401230>
+// DISASM-NEXT:                  calll   0x401240 <zed2+0x401240>
----------------
` <zed2+0x401230>` does not make much sense. Consider removing them when you are updating them. Next time llvm-objdump -d heuristics change for the target symbol, we won't need to fix them.


================
Comment at: lld/test/ELF/gnu-ifunc-plt.s:61
 // DISASM-NEXT:   <bar2 at plt>:
-// DISASM-NEXT:   201300:       jmpq    *8514(%rip)
-// DISASM-NEXT:   201306:       pushq   $0
-// DISASM-NEXT:   20130b:       jmp     0x2012f0 <.plt>
+// DISASM-NEXT:   201350:       jmpq    *8522(%rip) # 2034a0 <zed2+0x2034a0>
+// DISASM-NEXT:   201356:       pushq   $0
----------------
` <zed2+0x2034a0>` does not make much sense. Consider removing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85642/new/

https://reviews.llvm.org/D85642