[PATCH] D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 14:45:47 PDT 2020


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

As long as llvm/test/DebugInfo/Generic/global-sra-struct-zero-length.ll passes with this, I'm happy. LGTM



================
Comment at: llvm/test/DebugInfo/Generic/global-sra-struct-fwd-decl.ll:14-15
+
+; Check that the global variable "d" is not
+; emitted as a fragment if its struct type is
+; forward declared but d.c has zero length, so
----------------
Is there a `CHECK-NOT` we can add too to check that we don't observe a fragment for `d`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85572/new/

https://reviews.llvm.org/D85572



More information about the llvm-commits mailing list