[PATCH] D85585: Replace TableGen range piece punctuator with '..'
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 14:22:40 PDT 2020
dblaikie added a comment.
I don't really work with tablegen, so someone else will need to review the substance of this change.
One nit (provided inline) and one general question: does the '-' range separator produce any usability problems for users of tablegen, or does it only complicate the implementation? (though, admittedly, {-5--2} isn't terribly readable, so even if it works, I can see usability benefit in changing to {-5..-2})
================
Comment at: llvm/lib/TableGen/TGLexer.cpp:188-189
+ ++CurPtr; // Eat second period.
+ return tgtok::range;
+ } else {
+ return tgtok::period;
----------------
Avoid else after return: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85585/new/
https://reviews.llvm.org/D85585
More information about the llvm-commits
mailing list