[PATCH] D85458: Adding functionality to Stack Tracing

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Code looks good, but I'm still wondering if we could add test coverage? Can we test for `PrintStackTrace(StrOS, 1);` and validate that only one line is emitted? You could add such a test in one of the files in `llvm/unittests/Support/` - or add a new test file if it doesn't fit anywhere. Also don't forget to skip Windows OS (see the Host.cpp test for an example).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85458/new/

https://reviews.llvm.org/D85458