[PATCH] D85669: Fix "last accessed time" test failing on Windows

Mon Aug 10 13:56:58 PDT 2020

amccarth added a comment.

In D85669#2207983 <https://reviews.llvm.org/D85669#2207983>, @aganea wrote:

> In D85669#2207688 <https://reviews.llvm.org/D85669#2207688>, @amccarth wrote:
>
>> I'm OK with this.
>>
>> In an ideal world, it would be nice to ensure stripping preserves other the Windows creation timestamp while updating the last modification timestamp.
>
> Thanks Adrian. The "last modification time" is preserved with `llvm-strip -p`, see `llvm\test\tools\llvm-objcopy\ELF\strip-preserve-mtime.test` which works fine (if that's what you meant).

It's confusing because tests are defined in terms of Posix terminology and concepts that don't translate directly to non-Posix systems like Windows.  I guess that's fine for an ELF-specific option like `--preserve-dates`.

On Windows, without `--preserve-dates`, I would expect stripping in place to change the modification time but to preserve the file creation time.  As far as I understand, Posix file systems don't have an equivalent of a Windows file creation time, so I doubt there's a test for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85669/new/

https://reviews.llvm.org/D85669