[PATCH] D85550: [lld-macho] Implement -force_load

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:268
+              mb.getBufferIdentifier() +
+                  ": could not get the buffer for a child of the archive");
+    v.push_back(mbref);
----------------
compnerd wrote:
> Can we do any better in terms of diagnostics here?  Perhaps stringify the error?
`CHECK` does stringify the error


================
Comment at: lld/MachO/Driver.cpp:273
+    fatal(mb.getBufferIdentifier() +
+          ": Archive::children failed: " + toString(std::move(err)));
+
----------------
compnerd wrote:
> This seems ... duplicative.  The `fatal` is necessary, but Im not sure about printing out a subsequent message.
this doesn't duplicate the CHECK on line 266 -- it's reporting any errors returned by the `children()` call


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85550/new/

https://reviews.llvm.org/D85550