[PATCH] D68720: Support -fstack-clash-protection for x86

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1778
+  HelpText<"Enable stack clash protection">;
+def fnostack_clash_protection : Flag<["-"], "fnostack-clash-protection">, Group<f_Group>,
+  HelpText<"Disable stack clash protection">;
----------------
sberg wrote:
> Should this rather spell `"fno-stack-clash-protection"`?  The above change to clang/docs/ClangCommandLineReference.rst (but which got overwritten by <https://github.com/llvm/llvm-project/commit/9624beb38a46037f69362650a52e06d8be4fd006> "[docs] Regenerate ClangCommandLineReference.rst") mentions `-fno-stack-clash-protection`, and also GCC calls it like that.  (Though the below clang/test/Driver/stack-clash-protection.c does use `-fnostack-clash-protection`.)
And the fix should be backported to release branch.

@hans


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68720/new/

https://reviews.llvm.org/D68720