[PATCH] D85665: [SVE] Lower fixed length vector integer subtract operations.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3633
   case ISD::ADD:
-    if (useSVEForFixedLengthVectorVT(Op.getValueType()))
-      return LowerToPredicatedOp(Op, DAG, AArch64ISD::ADD_PRED);
-    llvm_unreachable("Unexpected request to lower ISD::ADD");
+    return LowerToPredicatedOp(Op, DAG, AArch64ISD::ADD_PRED);
   case ISD::AND:
----------------
efriedma wrote:
> Is the change to ISD::ADD here related somehow?
Only in that ADD and SUB should look pretty much identical and I didn't want to copy the "useSVE..." test, which I probably shouldn't have added in the first place for ADD.

Should I move this change into a separate patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85665/new/

https://reviews.llvm.org/D85665