[PATCH] D85458: Adding functionality to Stack Tracing

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Hello @dibya001!  Thanks for the patch!

Could you please explain your usage?

You would also need to add test coverage (in SupportTests maybe).



================
Comment at: llvm/include/llvm/Support/PrettyStackTrace.h:99
+
+    void setArgs(int argC, const char *const *argV) {
+      this->ArgV = argV;
----------------
Please explain why this is needed. How would things work out in your code if neither `setArgs` nor the empty constructor were there?


================
Comment at: llvm/lib/Support/Windows/Signals.inc:556
+void llvm::sys::PrintStackTrace(raw_ostream &OS, int Depth) {
   LocalPrintStackTrace(OS, nullptr);
 }
----------------
Implement this for Windows as well or add a `// FIXME:` if you can't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85458/new/

https://reviews.llvm.org/D85458