[PATCH] D83834: Add test utility 'split-file'

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 10:04:52 PDT 2020


aeubanks added a comment.

In D83834#2206034 <https://reviews.llvm.org/D83834#2206034>, @jhenderson wrote:

> In D83834#2201444 <https://reviews.llvm.org/D83834#2201444>, @aeubanks wrote:
>
>> There seem to be newline issues on Windows, causing llvm/test/tools/llvm-strings/radix.test and llvm/test/tools/split-file/basic.test to fail.
>>
>> $ xxd llvm/test/tools/split-file/Inputs/basic-aa.txt
>> 00000000: 0d0a 6161 0d0a                           ..aa..
>> $ xxd build_debug/obj/llvm/test/tools/split-file/Output/basic.test.tmp/aa
>> 00000000: 0a61 610d 0a                             .aa..
>>
>> Any simple fix?
>
> Have you got your git line-endings checkout settings correct? It's possible the `\r` is being added when you check out a file somewhere, I guess?

Yup that's it. https://llvm.org/docs/GettingStarted.html#checkout-llvm-from-git says to use autocrlf=false which I wasn't doing. I had to delete and restore those files to get the proper line endings, but now it's good, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834



More information about the llvm-commits mailing list