[PATCH] D85632: [Attributor] Implement AAPotentialValues and connect it with AAValueSimplify

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 09:29:49 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3490
-  BooleanState IsValidState;
-
   /// Container for potential values
----------------
I failed to determine why this cannot be private anymore.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:4513
+    return !failAll;
   }
 
----------------
Can you split this off into an NFC patch. Will make this one much simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85632/new/

https://reviews.llvm.org/D85632



More information about the llvm-commits mailing list