[PATCH] D85580: [flang] Fix assert on character literal substrings as arguments

[Peter Klausler via Phabricator via llvm-commits]

klausler added inline comments.


================
Comment at: flang/include/flang/Evaluate/variable.h:306
   CLASS_BOILERPLATE(Substring)
-  Substring(DataRef &&parent, std::optional<Expr<SubscriptInteger>> &&lower,
+  Substring(DataRef &&parent, int kind,
+      std::optional<Expr<SubscriptInteger>> &&lower,
----------------
Why does Substring need to have an explicit kind value -- can't this always be determined by the type of the parent string?


================
Comment at: flang/include/flang/Evaluate/variable.h:331
   }
+  std::optional<DynamicType> GetType() const {
+    return DynamicType(TypeCategory::Character, kind_);
----------------
Can't the type be computed from that of the Parent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85580/new/

https://reviews.llvm.org/D85580