[PATCH] D84822: Add target ID to AMDGPU documentation

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: clang/docs/ClangOffloadBundlerFileFormat.rst:88
+in `AMDGPU Embedding Bundled Code Objects
+  <https://llvm.org/docs/AMDGPUUsage.html#embedding-bundled-objects>`_.
----------------
jdoerfert wrote:
> This is not generic and ignores the fact that we use this tool for non-AMDGPU targets. The target-id description above does too.
fixed


================
Comment at: llvm/docs/AMDGPUUsage.rst:264
-                                                      [off]
-                                                    - cumode
-                                                      [off]
----------------
jdoerfert wrote:
> None of these changes seem related to "Add target ID to AMDGPU documentation".
xnack and sram-ecc are now set through target ID, and their default value are now changed to "default". As such, the default value of all features are now described in the "Target Features" section instead of in this table.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84822/new/

https://reviews.llvm.org/D84822