[PATCH] D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores()

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor comment.



================
Comment at: llvm/unittests/Support/Host.cpp:40
     // physical cores, which is currently only supported/tested for
-    // x86_64 Linux and Darwin.
+    // Linux (x86_64, PPC64, SystemZ), Darwin (x86_64), and for z/OS.
     return (Host.isOSWindows() && llvm_is_multithreaded()) ||
----------------
I think the comment doesn't need to indicate the list (note that the duplication led to Windows being in one list and not ther other). The comment does help in explaining what the function does though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85531/new/

https://reviews.llvm.org/D85531