[PATCH] D84765: [AIX][XCOFF] change the operand of branch instruction from symbol name to qualified symbol name for function declarations
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 06:43:42 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/include/llvm/MC/MCSymbolXCOFF.h:49
- bool hasRepresentedCsectSet() const { return RepresentedCsect != nullptr; }
-
MCSectionXCOFF *getRepresentedCsect() const;
----------------
nit: For the implementation of `getRepresentedCsect` and `setRepresentedCsect`, please remove
```
|| RepresentedCsect->getCSectType() == XCOFF::XTY_ER
```
and
```
|| C->getCSectType() == XCOFF::XTY_ER
```
from their asserts, as right now every RepresentedCsect symbol must be a qualname.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84765/new/
https://reviews.llvm.org/D84765
More information about the llvm-commits
mailing list