[PATCH] D85313: [DebugInfo] Don't error for zero-length arange entries

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 06:42:45 PDT 2020


Higuoxing accepted this revision.
Higuoxing added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!



================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-aranges.yaml:7-8
 # RUN: yaml2obj --docnum=1 -DBITS=32 -DENDIAN=LSB %s | obj2yaml | \
-# RUN:   FileCheck -DLENGTH1=24 -DLENGTH2=24 -DADDRSIZE=0x04 %s --check-prefix=BASIC --implicit-check-not=Sections
+# RUN:   FileCheck -DLENGTH1=24 -DLENGTH2=24 -DADDRSIZE=0x04 %s --check-prefix=BASIC --implicit-check-not=Sections \
+# RUN:     -DVARADDR=0x0000000000001234 -DVARLEN=0x0000000000005678
 
----------------
I think it might be good to put `-D` options together.

e.g.,
```
FileCheck -DLENGTH1=24 -DLENGTH2=24 -DADDRSIZE=0x04 -DVARADDR=0x1234 -DVARLEN=0x5678 %s --check-prefix=BASIC --implicit-check-not=Sections
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85313/new/

https://reviews.llvm.org/D85313



More information about the llvm-commits mailing list