[PATCH] D83560: [DebugInfo] Emit DW_OP_implicit_value for Floating point constants
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 05:21:43 PDT 2020
SouraVX updated this revision to Diff 284322.
SouraVX added a comment.
Thanks @MaskRay for pointers. Tried similar approach(slightly different, since expression has to be emitted by a separate streamer owned by `DebugLocDwarfExpression`) to take care of Endianess.
- Temporarily removed `long double` support since IMHO this might require a deeper surgery. Patch reflects the overall skeleton required for suporting `DW_OP_implicit_value`.
- @amyk, is it possible for you to try this patch on PPC targets ? So that we won't end up having surprises.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83560/new/
https://reviews.llvm.org/D83560
Files:
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
llvm/test/DebugInfo/X86/float_const_loclist.ll
llvm/test/DebugInfo/X86/implicit_value-double.ll
llvm/test/DebugInfo/X86/implicit_value-float.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83560.284322.patch
Type: text/x-patch
Size: 11035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200810/5a410529/attachment.bin>
More information about the llvm-commits
mailing list