[PATCH] D85636: [llvm-dwarfdump] Fix misleading scope byte coverage statistics

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 04:14:47 PDT 2020


Orlando created this revision.
Orlando added reviewers: djtodoro, aprantl, dblaikie.
Orlando added projects: debug-info, LLVM.
Herald added a reviewer: jhenderson.
Herald added subscribers: llvm-commits, cmtice.
Orlando requested review of this revision.
Herald added a subscriber: MaskRay.

Fixes PR46575 <https://bugs.llvm.org/show_bug.cgi?id=46575>.

Bump statistics version to 6.

Without this patch, for a variable described with a location list the stat
'sum_all_variables(#bytes in parent scope covered by DW_AT_location)' is
calculated by summing all bytes covered by the location ranges in the list and
capping the result to the number of bytes in the parent scope. With the patch,
only bytes which overlap with the parent DIE scope address ranges contribute to
the stat. A new stat 'sum_all_variables(#bytes of any scope covered by
DW_AT_location)' has been added which displays the total bytes covered when
ignoring scopes.


https://reviews.llvm.org/D85636

Files:
  llvm/test/tools/llvm-dwarfdump/X86/statistics-dwo.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics-v3.test
  llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85636.284309.patch
Type: text/x-patch
Size: 8675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200810/5b9a1bc6/attachment.bin>


More information about the llvm-commits mailing list