[PATCH] D85506: [macho2yaml] Refactor the DWARF section dumpers.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/MachO/debug-aranges.yaml:2
+## a) Test that we are able to dump the __debug_aranges section.
+## The content of the __debug_aranges section should be written to
+## the "DWARF" entry and the "content" field should remain empty.
----------------



================
Comment at: llvm/test/tools/obj2yaml/MachO/debug-aranges.yaml:78
+
+## d) Test dumping a __debug_aranges section whose length field doesn't match the actual length.
+## This makes the DWARF parser fail to parse it and we will dump it as a raw content section.
----------------



================
Comment at: llvm/test/tools/obj2yaml/MachO/debug-aranges.yaml:98
+
+## e) Test dumping a __debug_aranges section whose segname is __FOO.
+
----------------



================
Comment at: llvm/test/tools/obj2yaml/MachO/unrecognized-debug-section.yaml:46
+      - sectname:  __debug_foo
+        segname:   __FOO
+        addr:      0x00
----------------
You might want to explain with a comment the unusual segment name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85506/new/

https://reviews.llvm.org/D85506