[PATCH] D85624: [llvm-symbolizer] Add back --version and add a -v alias
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 10 02:22:21 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
You should add the short alias to the rst docs, same as other short aliases.
Aside from that and the inline comment, LGTM.
================
Comment at: llvm/test/tools/llvm-symbolizer/version.test:3
+# RUN: llvm-addr2line --version | FileCheck %s --check-prefixes=ADDR2LINE,COMMON
+# RUN: llvm-addr2line -v | FileCheck %s --check-prefixes=ADDR2LINE,COMMON
+
----------------
It probably makes sense to test the -v alias for llvm-symbolizer too, I reckon. Since we're adding support for it, we don't want to drop the alias in the future probably.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85624/new/
https://reviews.llvm.org/D85624
More information about the llvm-commits
mailing list