[PATCH] D85430: [llvm-readobj] - Refine logic of the symbol table locating in printRelocationsHelper().

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

I'm not convinced that this is the right approach, although I suppose I can understand it for simplicity. I think the original SHT_RELR proposal was mistaken to say there's an associated symbol table, since as you've already highlighted, it represents relative relocations. In fact, later versions of the proposal dropped this (see e.g. https://groups.google.com/g/generic-abi/c/bX460iggiKg/m/Jnz1lgLJAgAJ):

> The corresponding sh_link and sh_info values in the section header hold no special information.

I think it is actually therefore a mistake to try to treat sh_link as a symbol table reference, and as such, we shouldn't warn for SHT_RELR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85430/new/

https://reviews.llvm.org/D85430