[PATCH] D85299: [llvm] Support autoloading vendor-defined plugins

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur resigned from this revision.
Meinersbur added a comment.

The scenario sounds too specific for a single user requiring too much effort to maintain it across build configurations and platforms. Additionally, it makes clang's behavior dependent on the system configuration, which in the past the LLVM community was not in favor of. See http://lists.llvm.org/pipermail/cfe-dev/2016-September/050795.html.

There are a few other problems of this patch in particular:

1. Errors silently ignored
2. Does not handle new pass manager plugins
3. LLVM and Polly must exactly match, otherwise unpredictable errors occur. Picking up a plugin at some locations the user is not necessarily aware of is problematic.
4. Reproducibility is reduced: The output of `clang -v` doesn't even indicates that a pass is implicitly loaded.
5. Enlarges the build configuration space.

At most it saves the system maintainer from re-compiling LLVM with(/-out) `LLVM_POLLY_LINK_INTO_TOOLS=ON`. Sorry, I don't see myself supporting this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85299/new/

https://reviews.llvm.org/D85299