[PATCH] D85345: [BuildLibCalls] Add noundef to standard I/O functions

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 8 23:44:07 PDT 2020


aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:509
+    Changed |= setDoesNotThrow(F);
+    Changed |= setDoesNotCapture(F, 1);
+    return Changed;
----------------
jdoerfert wrote:
> I'd split it into noundef and other attributes. noundef is so new that we should keep that separate, having the others in a single patch is fine with me though.
Hi,
These attributes existed in the past - they are copied from lines 514-515.
This change was made because noundef is not added to frexp/frexpl/frexpf in this patch, which can possibly make those unspeculatable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85345/new/

https://reviews.llvm.org/D85345



More information about the llvm-commits mailing list