[PATCH] D83852: [llvm-profdata] Implement llvm-profdata overlap for sample profiles

Wei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 8 14:48:00 PDT 2020


weihe added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:811-817
+  bool areBothFinished() {
+    return (FirstIter == FirstEnd && SecondIter == SecondEnd);
+  }
+
+  bool isFirstFinished() { return FirstIter == FirstEnd; }
+
+  bool isSecondFinished() { return SecondIter == SecondEnd; }
----------------
hoyFB wrote:
> Can you please decorate these functions with `const`?
Thank you for this suggestion! I have added `const` keyword to the member functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83852/new/

https://reviews.llvm.org/D83852



More information about the llvm-commits mailing list