[PATCH] D85484: Properly form bundles in SplitKit

Fri Aug 7 11:00:55 PDT 2020

rampitec added a comment.

In D85484#2203273 <https://reviews.llvm.org/D85484#2203273>, @foad wrote:

>> consensus was a bundle without BOUNDLE instruction is illegal.
>
> I don't disagree with that, but I wonder why it isn't working the way D30438 <https://reviews.llvm.org/D30438> was designed. Is there some reason why expandCopyBundle is //not// unbundling all the BUNDLE-less bundles?

I do not think that is a good idea to unbundle just everything. Ideally this code shall only expand what was created by the SplitKit and do not touch what was bundled by an user code for any other reason.
Then do you think forming of an invalid bundle is a good idea to distinguish?
I am now playing with the change which will unboundle COPY and KILL bundles, not just COPY.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85484/new/

https://reviews.llvm.org/D85484