[PATCH] D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis

[rithik sharma via Phabricator via llvm-commits]

RithikSharma marked 4 inline comments as done.
RithikSharma added a comment.

Thanks for the reviews @Whitney , I have updated the patch with the changes.



================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:252
+      return false;
+    auto DestMemLoc = MemoryLocation::get(Inst);
+
----------------
Whitney wrote:
> RithikSharma wrote:
> > bmahjour wrote:
> > > MemoryLocation::get returns "none" if Inst is a call. Please add special handling for calls and make sure your tests cover it.
> > Test case pending.
> Is the test cases for call going to be added in this patch?
Test cases are present in https://reviews.llvm.org/D84776


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84589/new/

https://reviews.llvm.org/D84589