[PATCH] D85368: [llvm][CodeGen] Machine Function Splitter

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunctionSplitter.cpp:77
+
+  MF.RenumberBlocks();
+  MF.setBBSectionsType(BasicBlockSection::Preset);
----------------
snehasish wrote:
> tmsriram wrote:
> > hiraditya wrote:
> > > Do we need to renumber?
> > Renumbering makes the sorting easy.  The sorting will preserve the basic block order for the blocks that are not split.
> We need to ensure that the order is preserved so that we don't perturb the decisions made by prior passes such as MachineBlockPlacement. Renumbering simplifies the code that needs to be shared with the BasicBlockSections pass.
I see we are renumbering both in MachineFunctionSplitter and BasicBlockSections


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85368/new/

https://reviews.llvm.org/D85368