[PATCH] D85387: [NFC] Make argument name passed to `FindAvailableMemoryRange()` consistent with parameter name.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 7 16:18:57 PDT 2020
tejohnson added a comment.
In D85387#2200792 <https://reviews.llvm.org/D85387#2200792>, @tejohnson wrote:
> In D85387#2200680 <https://reviews.llvm.org/D85387#2200680>, @delcypher wrote:
>
>> @tejohnson Side comment about the refactor. The comments on `MapDynamicShadow(...)` say that is function is actually supposed to mmap the found memory as NO_ACCESS. The current implementation doesn't do this. It just finds a space but doesn't mmap it. Is this a problem?
>
> Thanks for pointing that out. That comment came from the linux version, where it is true, but it isn't true on mac or win. I will adjust the comment to say "on linux mapped no access".
Fixed comment in bb1456decf5e09947dfe8eee47b9736de7cd7f47 <https://reviews.llvm.org/rGbb1456decf5e09947dfe8eee47b9736de7cd7f47>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85387/new/
https://reviews.llvm.org/D85387
More information about the llvm-commits
mailing list