[PATCH] D85493: [NewPM] Print 'Skipping pass' as pass instrumentation

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:314
+      [SpecialPasses](StringRef PassID, Any IR) {
+        if (isSpecialPass(PassID, SpecialPasses))
+          return;
----------------
We probabaly don't need to check adaptor&pass manager here because they are never skipped.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:317
+
+        dbgs() << "Skipping pass: " << PassID << "\n";
+      });
----------------
It would be more clear to also print the IR name as `registerBeforeNonSkippedPassCallback` did (using `unwrapAndPrint`) .


================
Comment at: llvm/test/Feature/optnone-opt.ll:95
+
+; VerifierPass should not be skipped
+; NPM-VERIFY-NOT: Skipping pass
----------------
Yeah, we don't have a required user pass yet to test. And I would rather not special-casing Verifer pass for this. How about, instead of doing this, extending `NPM-LOOP` check with IR names so we know the new code path is covered. We could defer the `required` passes testing for the future. There are some candidate machine passes that could be marked required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85493/new/

https://reviews.llvm.org/D85493