[PATCH] D84937: [SVE][CodeGen] Fix scalable vector issues in DAGTypeLegalizer::GenWidenVectorStores

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5157
+      Type *NewTy = NewVT.getTypeForEVT(*DAG.getContext());
+      NewAlign = DAG.getDataLayout().getPrefTypeAlign(NewTy);
+    } else
----------------
efriedma wrote:
> getPrefTypeAlign() isn't related to anything relevant.  We need to compute the common alignment based on the original alignment, the offset of the original MachinePointerInfo, and the current offset.
Something like `commonAlignment(ST->getAlign(), Idx * ValEltWIdth)`, I guess?  Maybe some better way to compute the offset so far from the loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84937/new/

https://reviews.llvm.org/D84937