[PATCH] D85544: [OpenMPOpt] ICV tracking for calls

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Cool! Can you describe in the commit message in more detail what is different in this approach, how it works in general. Maybe pros and cons compared to before?



================
Comment at: llvm/test/Transforms/OpenMP/icv_tracking.ll:281
+}
+
 define void @test2(i1 %0) {
----------------
Can we have more negative test cases too?
1) this function with weak linkage, should be handled by the Attributor already but let's make sure we verify.
2) two returns with different ICV values, e.g. unknown and known, or two different known ones.
3) not a call but an invoke of a function with a call to a unknown one that may throw. I guess we can/should just not propagate over invokes now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85544/new/

https://reviews.llvm.org/D85544