[PATCH] D85522: [Loads] Globals are dereferenceable, if offset + size <= sizeof(global).

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 12:11:14 PDT 2020


jdoerfert added a comment.

IIRC, not all globals are dereferenceable and we have to look at the linkage. Could be wrong though.

This needs a test for sure.

Why `* 8` isn't size in bytes too?

Shouldn't we handle gep+global in `Value::getPointerDereferenceableBytes` instead, that should make this unnecessary, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85522/new/

https://reviews.llvm.org/D85522



More information about the llvm-commits mailing list