[PATCH] D85534: Enable InsertFreeze flag of JumpThreading when used in LTO
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 7 09:19:20 PDT 2020
aqjune created this revision.
aqjune added reviewers: efriedma, jdoerfert, eugenis, nikic, lebedev.ri, spatel.
Herald added subscribers: llvm-commits, dexonsmith, hiraditya, inglorion.
Herald added a project: LLVM.
aqjune requested review of this revision.
This patch enables inserting freeze when JumpThreading converts a select to
a conditional branch when it is run in LTO.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D85534
Files:
llvm/lib/Passes/PassBuilder.cpp
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
Index: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
===================================================================
--- llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
+++ llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
@@ -998,7 +998,7 @@
// The IPO passes may leave cruft around. Clean up after them.
PM.add(createInstructionCombiningPass());
addExtensionsToPM(EP_Peephole, PM);
- PM.add(createJumpThreadingPass());
+ PM.add(createJumpThreadingPass(/*FreezeSelectCond*/ true));
// Break up allocas
PM.add(createSROAPass());
@@ -1061,7 +1061,7 @@
PM.add(createInstructionCombiningPass());
addExtensionsToPM(EP_Peephole, PM);
- PM.add(createJumpThreadingPass());
+ PM.add(createJumpThreadingPass(/*FreezeSelectCond*/ true));
}
void PassManagerBuilder::addLateLTOOptimizationPasses(
Index: llvm/lib/Passes/PassBuilder.cpp
===================================================================
--- llvm/lib/Passes/PassBuilder.cpp
+++ llvm/lib/Passes/PassBuilder.cpp
@@ -1494,7 +1494,7 @@
FPM.addPass(InstCombinePass());
invokePeepholeEPCallbacks(FPM, Level);
- FPM.addPass(JumpThreadingPass());
+ FPM.addPass(JumpThreadingPass(/*InsertFr*/ true));
// Do a post inline PGO instrumentation and use pass. This is a context
// sensitive PGO pass.
@@ -1561,7 +1561,7 @@
MainFPM.addPass(InstCombinePass());
invokePeepholeEPCallbacks(MainFPM, Level);
- MainFPM.addPass(JumpThreadingPass());
+ MainFPM.addPass(JumpThreadingPass(/*InsertFr*/ true));
MPM.addPass(createModuleToFunctionPassAdaptor(std::move(MainFPM)));
// Create a function that performs CFI checks for cross-DSO calls with
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85534.283926.patch
Type: text/x-patch
Size: 1649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200807/9673e823/attachment.bin>
More information about the llvm-commits
mailing list