[PATCH] D85494: [WebAssembly] Allow inlining functions with different features

[Alex Crichton via Phabricator via llvm-commits]

alexcrichton added a comment.

Ah that's actually a good point. I think in that case it may be best to only inline into functions which have a superset of features. A pretty common expected use is where you enable simd128 in some functions and then call a bunch of intrinsics. The standard library itself won't be compiled with simd128 by default, so that'll be the only way to use simd128.

We could recognize that if any feature is used anywhere in a module we enable it for the module, but that would behave pretty wasm-specific compared to other targets, so it's probably best to do a subset check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85494/new/

https://reviews.llvm.org/D85494