[PATCH] D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe

Fri Aug 7 08:06:05 PDT 2020

spatel added a comment.

In D84250#2202732 <https://reviews.llvm.org/D84250#2202732>, @aqjune wrote:

> Should we go to D84792 <https://reviews.llvm.org/D84792>'s direction?
> If it is, I think we should mention that it is a workaround for the miscompilations including PR33165, and it can still be problematic in theory but chose to do it for performance.

I don't have a preference, but others said they would like go with D84792 <https://reviews.llvm.org/D84792>, so let's do that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84250/new/

https://reviews.llvm.org/D84250