[PATCH] D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation

Fri Aug 7 05:05:03 PDT 2020

nemanjai added inline comments.

================
Comment at: lld/ELF/Relocations.h:99
   R_PPC64_TOCBASE,
+  R_PPC64_RELAX_GOT_PCREL34,
   R_RISCV_ADD,
----------------
nemanjai wrote:
> sfertile wrote:
> > Should we drop the 'REL34' in the Expr? Its not really important how many bits it represents, and I think the REL is implied by 'PC' in `R_RELAX_GOT_PC`.
> > 
> > Also, should it be added to `isRelExpr` in `Relocations.cpp`?
> > Should we drop the 'REL34' in the Expr? Its not really important how many bits it represents, and I think the REL is implied by 'PC' in `R_RELAX_GOT_PC`.
> I am definitely OK with this.
> > 
> > Also, should it be added to `isRelExpr` in `Relocations.cpp`?
> This is just an omission on my part as I didn't know that existed. I'll add it.
> 
Just to be clear, the name you are suggesting is `R_PPC64_RELAX_GOT_PC`, correct? I don't imagine you would like me to drop `PPC64` since this is specific to this target.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84360/new/

https://reviews.llvm.org/D84360