[PATCH] D85377: [PowerPC] Add option to control PCRel GOT indirect linker optimization

Fri Aug 7 05:12:45 PDT 2020

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

I agree with Victor, please remove uses of `future` and use `pwr10`. All of this can be addressed when committing - another round of review is not required. LGTM.

================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-linkeropt-option.ll:14
+
+define dso_local i8 @Read8() local_unnamed_addr #0 {
+; DEFAULT-LABEL: Read8:
----------------
NeHuang wrote:
> nit: Do we need to keep `#0` and `attributes #0 = { nounwind }` below?
Yeah, this doesn't get a stack frame so we gain nothing by having this. Please remove it in this case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85377/new/

https://reviews.llvm.org/D85377