[PATCH] D85515: [llvm-readobj] - Remove 3 excessive test cases.

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, atanasyan.
Herald added subscribers: llvm-commits, rupprecht, kbarton, arichardson, nemanjai, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
grimar requested review of this revision.
Herald added a subscriber: wuzish.

This patch does the following:

1. Removes `mips-options.test` and the corresponding `Inputs/mips-options.elf-mips64el` binary:

This is a test that checks that `--dynamic-table` is able to print the `DT_MIPS_OPTIONS` tag.
We are testing it in `dynamic-tags-machine-specific.test` already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L235)

2. Removes `mips-rld-map-rel.test` and the corresponding `Inputs/mips-rld-map-rel.elf-mipsel` binary.

This is a test that checks that `--dynamic-table` is able to print the `DT_MIPS_RLD_MAP_REL` tag.
We are testing it in `dynamic-tags-machine-specific.test` already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L257)

3. Removes `ppc64-glink.test` test and the corresponding `Inputs/ppc64.exe` binary.

This is a test that checks that `--dynamic-table` is able to print the `DT_PPC64_GLINK` tag.
We are testing it in `dynamic-tags-machine-specific.test` already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L337)


https://reviews.llvm.org/D85515

Files:
  llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el
  llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel
  llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe
  llvm/test/tools/llvm-readobj/ELF/mips-options.test
  llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
  llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test


Index: llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test
+++ /dev/null
@@ -1,11 +0,0 @@
-# Check DT_PPC64_GLINK dynamic tag.
-
-RUN: llvm-readobj --dynamic-table %p/Inputs/ppc64.exe | FileCheck %s
-
-CHECK: Format: elf64-powerpc
-CHECK: Arch: powerpc64le
-CHECK: AddressSize: 64bit
-
-CHECK:      DynamicSection [ (25 entries)
-CHECK-NEXT:   Tag                Type                 Name/Value
-CHECK:        0x0000000070000000 PPC64_GLINK          0x10000830
Index: llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test
+++ /dev/null
@@ -1,24 +0,0 @@
-## Check DT_MIPS_RLD_MAP_REL .dynamic section tag reading
-
-# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-rld-map-rel.elf-mipsel | \
-# RUN:   FileCheck %s
-
-# CHECK:      DynamicSection [ (16 entries)
-# CHECK-NEXT:   Tag                Type                 Name/Value
-# CHECK-NEXT:   0x00000004 HASH                 0x220
-# CHECK-NEXT:   0x00000005 STRTAB               0x2FC
-# CHECK-NEXT:   0x00000006 SYMTAB               0x25C
-# CHECK-NEXT:   0x0000000A STRSZ                72 (bytes)
-# CHECK-NEXT:   0x0000000B SYMENT               16 (bytes)
-# CHECK-NEXT:   0x70000035 MIPS_RLD_MAP_REL     0x101E0
-# CHECK-NEXT:   0x00000015 DEBUG                0x0
-# CHECK-NEXT:   0x00000003 PLTGOT               0x10390
-# CHECK-NEXT:   0x70000001 MIPS_RLD_VERSION     1
-# CHECK-NEXT:   0x70000005 MIPS_FLAGS           NOTPOT
-# CHECK-NEXT:   0x70000006 MIPS_BASE_ADDRESS    0x0
-# CHECK-NEXT:   0x7000000A MIPS_LOCAL_GOTNO     2
-# CHECK-NEXT:   0x70000011 MIPS_SYMTABNO        10
-# CHECK-NEXT:   0x70000012 MIPS_UNREFEXTNO      15
-# CHECK-NEXT:   0x70000013 MIPS_GOTSYM          0xA
-# CHECK-NEXT:   0x00000000 NULL                 0x0
-# CHECK-NEXT: ]
Index: llvm/test/tools/llvm-readobj/ELF/mips-options.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/mips-options.test
+++ /dev/null
@@ -1,22 +0,0 @@
-## Check DT_MIPS_OPTIONS .dynamic section tag reading
-
-# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-options.elf-mips64el | \
-# RUN:   FileCheck %s
-
-# CHECK:      DynamicSection [ (14 entries)
-# CHECK-NEXT:   Tag                Type                 Name/Value
-# CHECK-NEXT:   0x0000000000000004 HASH                 0x158
-# CHECK-NEXT:   0x0000000000000005 STRTAB               0x1C0
-# CHECK-NEXT:   0x0000000000000006 SYMTAB               0x178
-# CHECK-NEXT:   0x000000000000000A STRSZ                7 (bytes)
-# CHECK-NEXT:   0x000000000000000B SYMENT               24 (bytes)
-# CHECK-NEXT:   0x0000000070000001 MIPS_RLD_VERSION     1
-# CHECK-NEXT:   0x0000000070000005 MIPS_FLAGS           NOTPOT
-# CHECK-NEXT:   0x0000000070000006 MIPS_BASE_ADDRESS    0x0
-# CHECK-NEXT:   0x000000007000000A MIPS_LOCAL_GOTNO     2
-# CHECK-NEXT:   0x0000000070000011 MIPS_SYMTABNO        3
-# CHECK-NEXT:   0x0000000070000013 MIPS_GOTSYM          0x3
-# CHECK-NEXT:   0x0000000000000003 PLTGOT               0x2000
-# CHECK-NEXT:   0x0000000070000029 MIPS_OPTIONS         0x1000
-# CHECK-NEXT:   0x0000000000000000 NULL                 0x0
-# CHECK-NEXT: ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85515.283867.patch
Type: text/x-patch
Size: 3346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200807/5160a914/attachment.bin>