[PATCH] D85506: [macho2yaml] Refactor the DWARF section dumpers.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/tools/obj2yaml/macho2yaml.cpp:29
+      const llvm::object::MachOObjectFile::LoadCommandInfo &LoadCmd,
+      std::unique_ptr<MachOYAML::Object> &Y);
 
----------------
grimar wrote:
> Probably, `std::unique_ptr<MachOYAML::Object> &Y` -> `const MachOYAML::Object &Y`
> would express the intention better (doesn't seem you need the ability to really access/change the `std::unique_ptr<...>` holder of `Y`).
`Y.DWARF` is modified in `dumpDebugSection()`, so I change it to `MachOYAML::Object &Y`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85506/new/

https://reviews.llvm.org/D85506