[PATCH] D83834: Add test utility 'split-file'

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D83834#2201665 <https://reviews.llvm.org/D83834#2201665>, @MaskRay wrote:

> In D83834#2201444 <https://reviews.llvm.org/D83834#2201444>, @aeubanks wrote:
>
>> There seem to be newline issues on Windows, causing llvm/test/tools/llvm-strings/radix.test and llvm/test/tools/split-file/basic.test to fail.
>>
>> $ xxd llvm/test/tools/split-file/Inputs/basic-aa.txt
>> 00000000: 0d0a 6161 0d0a                           ..aa..
>> $ xxd build_debug/obj/llvm/test/tools/split-file/Output/basic.test.tmp/aa
>> 00000000: 0a61 610d 0a                             .aa..
>>
>> Any simple fix?
>
> This is strange. A Windows bot I usually look was good: http://45.33.8.238/win/summary.html
>
> Can you please check why '\r' is printed? The output is opened with OF_None (not OF_Text), so I don't expect '\r' to be printed.
>
> At the least `diff -b` can be used.

FWIW, I've tested this and all tests in \llvm\test\tools\split-file folder pass fine for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834