[PATCH] D85504: [Reassociate] [PowerPC] stop common out mul factors if fma is preferred on target

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

(can you please maybe spellcheck both the patch description and the wording within the patch? it is really hard to read)

I'm not really sure this is the way forward.

1. This is a target-agnostic pass, it we add arbitrary restrictions it will likely miss some intended transforms
2. As usual, just preventing some transform is not the solution, because you can still have "bad" input that will still be lowered badly

IOW,

1. why not reverse this, as usual, in DAGCombine
2. this needs something like D67383 <https://reviews.llvm.org/D67383> Tree-Height-Reduction, i guess, for more general reverse transform


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85504/new/

https://reviews.llvm.org/D85504