[PATCH] D85080: [lld-macho] Support static linking of thread-locals

Thu Aug 6 19:17:45 PDT 2020

int3 marked an inline comment as done.
int3 added inline comments.

================
Comment at: lld/MachO/InputSection.cpp:41
+
+      if (isThreadLocalVariables(flags)) {
+        // References from thread-local variable sections are treated as
----------------
smeenai wrote:
> int3 wrote:
> > smeenai wrote:
> > > Is this not being put in `resolveSymbolVA` because it's target-independent?
> > > 
> > > Also, this is pretty strange ... I wonder why it's set up like this.
> > yup, I think it's target-independent
> Can you double check against ld64 to make sure that's the case? If so, this LGTM.
Yeah, `src/ld/passes/tlvp.cpp` does this in a target-independent manner.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85080/new/

https://reviews.llvm.org/D85080