[PATCH] D84347: [MLIR,OpenMP] Lowering of parallel operation: proc_bind clause 2/n

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 19:02:23 PDT 2020


clementval requested changes to this revision.
clementval added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/utils/TableGen/DirectiveEmitter.cpp:207
+  for (const auto &R : Records) {
+    const auto &ClauseVals = R->getValueAsListOfDefs("allowedClauseValues");
+    if (ClauseVals.size() <= 0)
----------------
We now have small wrapper to access record information -> https://github.com/llvm/llvm-project/blob/master/llvm/utils/TableGen/DirectiveEmitter.cpp#L135

Can you use them and add one for ClauseVal?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84347/new/

https://reviews.llvm.org/D84347



More information about the llvm-commits mailing list