[PATCH] D85238: [LLParser,NFC] Simplify forward GV refs update

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 17:02:55 PDT 2020


vitalybuka added a comment.

In D85238#2201212 <https://reviews.llvm.org/D85238#2201212>, @tejohnson wrote:

> That certainly looks cleaner, can't recall why I wrote it the original way. But why does this depend on D85182 <https://reviews.llvm.org/D85182>? I must be missing something.

Oh no, it's not dependent at all. it's just on the same my local branch so "arc diff" added dependency.

D85269 <https://reviews.llvm.org/D85269> also is not strictly depend on this. Maybe just consistency as D85269 <https://reviews.llvm.org/D85269> already use [] instead of insert for the similar code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85238/new/

https://reviews.llvm.org/D85238



More information about the llvm-commits mailing list