[PATCH] D85313: [DebugInfo] Don't error for zero-length arange entries

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D85313#2199447 <https://reviews.llvm.org/D85313#2199447>, @jhenderson wrote:

> @dblaikie - are you happy with this version?

Sounds good to me!

> I'd prefer not to - as noted elsewhere, our downstream solution for gc'ed references from .debug_aranges was to patch (-1, 0) for the .debug_aranges, so we have plenty of older objects with length 0 entries. At some point in the future these will start disappearing, now that we've moved to the new LLD tombstoning behaviour, but it would be nice to have a grace period, if that's okay?

Oh, interesting - didn't realize your linker specifically truncated the range to 0 length, that totally makes sense! But now you're adopting the "new tombstoning" Semantics of -1 for the address, but leaving the length value the same as came from the input object?

I personally have no particular use for the DWARF verifier - so I'm not in a position to make strong preferences for what should or shouldn't be verified. Hopefully as a warning it might be something relatively easy to patch out in your downstream builds (not ideal, I know :/), or filter out, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85313/new/

https://reviews.llvm.org/D85313