[PATCH] D85484: Properly form bundles in SplitKit

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 15:50:50 PDT 2020


rampitec created this revision.
rampitec added reviewers: arsenm, kerbowa.
Herald added subscribers: hiraditya, tpr, nhaehnle, jvesely.
Herald added a project: LLVM.
rampitec requested review of this revision.
Herald added a subscriber: wdng.

SplitKit forms invalid COPY subreg bundles without a leading
BUNDLE instruction. That manifests itself in post-RA scheduler
counting instruction and asserting on "Instruction count mismatch".

Fix both SplitKit to properly form bundles and expandCopyBundle
in VirtRegRewriter to handle bundle instructions.

Finally we need either to unpack bundles before emission or
handle KILLs. At the moment kills are only handled in the
AsmPrinter itself and it does not handle bundles and AMDGPU does
not have a code to emit them.


https://reviews.llvm.org/D85484

Files:
  llvm/lib/CodeGen/SplitKit.cpp
  llvm/lib/CodeGen/VirtRegMap.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/test/CodeGen/AMDGPU/splitkit-copy-bundle.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85484.283756.patch
Type: text/x-patch
Size: 8462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200806/818f2c91/attachment.bin>


More information about the llvm-commits mailing list